Loki: Increase flush_op_timeout default from 10s to 10m #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig WAL replay which can generate a lot of chunks very quickly. Signed-off-by: Ed Welch <edward.welch@grafana.com>
slim-bean
added
the
backport release-2.5.x
owen-d
approved these changes
Apr 4, 2022
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
…ig WAL replay which can generate a lot of chunks very quickly. (grafana#5768) (grafana#5771) Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit b136d0d) Co-authored-by: Ed Welch <edward.welch@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Under normal operation the flush queue generally doesn't get too large and flush operations can completely fairly quickly. However, sometimes if the remote storage is slow, the remote storage is unavailable for a period, or when replaying a very large WAL it's possible to build a big enough flush queue that a flush operation needs more than 10s to complete.
Another more interesting question is, what should the upper bound of this operation really be? This is hard for me to answer, I think all operations should have a timeout so it seems like waiting forever here isn't ideal, but is 10m enough?
This is related to some discoveries in #5267